Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3603)

Unified Diff: chrome/common/extensions/api/_api_features.json

Issue 443723003: extensions: Register 'app' and 'webstore' bindings only if they are available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/api/extension_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/_api_features.json
diff --git a/chrome/common/extensions/api/_api_features.json b/chrome/common/extensions/api/_api_features.json
index eb3047dd09b12cc878a125c10a39381b9665665a..0280fca08db084596e80fe3a636c2b78215e33db 100644
--- a/chrome/common/extensions/api/_api_features.json
+++ b/chrome/common/extensions/api/_api_features.json
@@ -53,9 +53,8 @@
"web_page",
"blessed_web_page"
],
- "matches": [
- "http://*/*", "https://*/*", "chrome-extension://*/*", "file://*/*"
- ]
+ // Any webpage can use the app API.
+ "matches": ["<all_urls>"]
},
"appViewInternal": {
"internal": true,
@@ -763,12 +762,14 @@
"webstore": {
// Hosted apps can use the webstore API from within a blessed context.
"channel": "stable",
- // Do not specify extension_types to prevent webstore from being filtered.
+ // Set extension_types to 'all' to prevent webstore from being filtered.
// Technically, webstore is not in apps or extensions, but it is currently
- // displayed on /extensions/webstore and /apps/webstore.
+ // displayed on /extensions/webstore and /apps/webstore. The "contexts"
+ // restriction effectively restricts this to hosted apps and webpages.
+ "extension_types": "all",
"contexts": ["blessed_web_page", "web_page"],
// Any webpage can use the webstore API.
- "matches": ["http://*/*", "https://*/*"]
+ "matches": ["<all_urls>"]
},
"webstorePrivate": {
"dependencies": ["permission:webstorePrivate"],
« no previous file with comments | « no previous file | chrome/common/extensions/api/extension_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698