extensions: Register 'app' and 'webstore' bindings only if they are available.

extensions/common/features/simple_feature.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/features/simple_feature.h"
 
 #include <map>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/alias.h"
 #include "base/lazy_instance.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "extensions/common/extension_api.h"
 #include "extensions/common/features/feature_provider.h"
+#include "extensions/common/permissions/permissions_data.h"
 #include "extensions/common/switches.h"
 
 namespace extensions {
 
 namespace {
 
 Feature::Availability IsAvailableToManifestForBind(
     const std::string& extension_id,
     Manifest::Type type,
     Manifest::Location location,
@@ skipping 369 matching lines @@
       return result;
   }
 
   if (!contexts_.empty() && contexts_.find(context) == contexts_.end())
     return CreateAvailability(INVALID_CONTEXT, context);
 
   // TODO(kalman): Consider checking |matches_| regardless of context type.
   // Fewer surprises, and if the feature configuration wants to isolate
   // "matches" from say "blessed_extension" then they can use complex features.
   if ((context == WEB_PAGE_CONTEXT || context == WEBUI_CONTEXT) &&
-      !matches_.MatchesURL(url)) {
+      (!matches_.MatchesURL(url) ||
+       (url.is_valid() &&

[sadrul, 2014/08/06 18:51:51]

The check for url.is_valid() is here because
ExtensionAPI::IsAvailableInUntrustedContext() uses an empty URL, which fails in
PermissionsData::IsRestrictedUrl(), causing failure in some tests.

[not at google - send to devlin, 2014/08/06 22:10:28]

damn, it looks like this check is breaking the webui tests. oh well, let's just
forget about it and change the test expectation after all.

+        PermissionsData::IsRestrictedUrl(url, url, extension, NULL)))) {
     return CreateAvailability(INVALID_URL, url);
   }
 
   for (FilterList::const_iterator filter_iter = filters_.begin();
        filter_iter != filters_.end();
        ++filter_iter) {
     Availability availability =
         (*filter_iter)->IsAvailableToContext(extension, context, url, platform);
     if (!availability.is_available())
       return availability;
@@ skipping 152 matching lines @@
     if (!dependency)
       return CreateAvailability(NOT_PRESENT);
     Availability dependency_availability = checker.Run(dependency);
     if (!dependency_availability.is_available())
       return dependency_availability;
   }
   return CreateAvailability(IS_AVAILABLE);
 }
 
 }  // namespace extensions