Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 443703002: athena: Bundle a static background image with athena. (Closed)

Created:
6 years, 4 months ago by sadrul
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

athena: Bundle a static background image with athena. BUG=none R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287904

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : whoops #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M athena/athena.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M athena/main/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M athena/main/athena_main.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M athena/main/placeholder.cc View 1 2 chunks +5 lines, -11 lines 0 comments Download
A athena/resources/athena_resources.grd View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M athena/resources/athena_resources.gyp View 3 chunks +19 lines, -0 lines 0 comments Download
A athena/resources/default_100_percent/background_wallpaper.png View Binary file 0 comments Download
A athena/resources/default_200_percent/background_wallpaper.png View Binary file 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
6 years, 4 months ago (2014-08-05 19:41:39 UTC) #1
oshima
lgtm https://codereview.chromium.org/443703002/diff/40001/athena/resources/athena_resources.grd File athena/resources/athena_resources.grd (right): https://codereview.chromium.org/443703002/diff/40001/athena/resources/athena_resources.grd#newcode13 athena/resources/athena_resources.grd:13: <structure type="chrome_scaled_image" name="IDR_ATHENA_BACKGROUND" file="background_wallpaper.png" /> Note: Wallpaper images ...
6 years, 4 months ago (2014-08-06 19:53:20 UTC) #2
sadrul
https://codereview.chromium.org/443703002/diff/40001/athena/resources/athena_resources.grd File athena/resources/athena_resources.grd (right): https://codereview.chromium.org/443703002/diff/40001/athena/resources/athena_resources.grd#newcode13 athena/resources/athena_resources.grd:13: <structure type="chrome_scaled_image" name="IDR_ATHENA_BACKGROUND" file="background_wallpaper.png" /> On 2014/08/06 19:53:20, oshima ...
6 years, 4 months ago (2014-08-06 20:22:42 UTC) #3
sadrul
6 years, 4 months ago (2014-08-07 00:04:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as 287904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698