Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: native_client_sdk/src/libraries/nacl_io/socket/packet.h

Issue 443693002: [NaCl SDK] nacl_io: Remove use of new/delete for data buffers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_io/socket/packet.h
diff --git a/native_client_sdk/src/libraries/nacl_io/socket/packet.h b/native_client_sdk/src/libraries/nacl_io/socket/packet.h
index bcae9131a3d873d33177257dc0a37378bb746298..ce199e65d5e9310b8ce8ffacf028f99bd0b949a4 100644
--- a/native_client_sdk/src/libraries/nacl_io/socket/packet.h
+++ b/native_client_sdk/src/libraries/nacl_io/socket/packet.h
@@ -14,8 +14,7 @@ namespace nacl_io {
class PepperInterface;
-// NOTE: The Packet class always owns the buffer and address, either by 'Copy'
-// or by 'Take' ownership.
+// NOTE: The Packet class always owns the buffer and address.
class Packet {
public:
explicit Packet(PepperInterface* ppapi);
@@ -24,9 +23,6 @@ class Packet {
// Copy the buffer, and address reference
void Copy(const void* buffer, size_t len, PP_Resource addr);
- // Take ownership the buffer, and address reference
- void Take(const void* buffer, size_t len, PP_Resource addr);
-
char* buffer() { return buffer_; }
PP_Resource addr() { return addr_; }
size_t len() { return len_; }
« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/socket/fifo_packet.h ('k') | native_client_sdk/src/libraries/nacl_io/socket/packet.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698