[NaCl SDK] nacl_io: Remove use of new/delete for data buffers.

native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/httpfs/http_fs.h"
 
 #include <assert.h>
 #include <ctype.h>
 #include <errno.h>
 #include <fcntl.h>
@@ skipping 208 matching lines @@
         url_root_ += '/';
       }
     } else if (iter->first == "manifest") {
       char* text;
       error = LoadManifest(iter->second, &text);
       if (error)
         return error;
 
       error = ParseManifest(text);
       if (error) {
-        delete[] text;
+        free(text);
         return error;
       }
 
-      delete[] text;
+      free(text);
     } else if (iter->first == "allow_cross_origin_requests") {
       allow_cors_ = iter->second == "true";
     } else if (iter->first == "allow_credentials") {
       allow_credentials_ = iter->second == "true";
     } else if (iter->first == "cache_stat") {
       cache_stat_ = iter->second == "true";
     } else if (iter->first == "cache_content") {
       cache_content_ = iter->second == "true";
     } else {
       // Assume it is a header to pass to an HTTP request.
@@ skipping 145 matching lines @@
 
   int error = Open(manifest_path, O_RDONLY, &manifest_node);
   if (error)
     return error;
 
   off_t size;
   error = manifest_node->GetSize(&size);
   if (error)
     return error;
 
-  char* text = new char[size + 1];
+  char* text = (char*)malloc(size + 1);
+  assert(text != NULL);

[binji, 2014/08/06 17:17:59]

could return error here?

[Sam Clegg, 2014/08/07 11:49:52]

Done.

   int len;
   error = manifest_node->Read(HandleAttr(), text, size, &len);
   if (error)
     return error;
 
   text[len] = 0;
   *out_manifest = text;
   return 0;
 }
 
 std::string HttpFs::MakeUrl(const Path& path) {
   return url_root_ +
          (path.IsAbsolute() ? path.Range(1, path.Size()) : path.Join());
 }
 
 }  // namespace nacl_io