[NaCl SDK] nacl_io: Remove use of new/delete for data buffers.

native_client_sdk/src/libraries/nacl_io/fifo_char.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/fifo_char.h"
 
 #include <stdlib.h>
 #include <string.h>
 
 #include <algorithm>
 
 namespace nacl_io {
 
 FIFOChar::FIFOChar(size_t size)
     : buffer_(NULL), size_(size), avail_(0), tail_(0) {
   if (size)
-    buffer_ = new char[size];
+    buffer_ = (char*)malloc(size);

[binji, 2014/08/05 19:30:29]

we should probably check for NULL returns for all mallocs/reallocs.

[Sam Clegg, 2014/08/06 09:10:32]

Done. Although there is not much useful we can do in 
most cases.

 }
 
 FIFOChar::~FIFOChar() {
-  delete[] buffer_;
+  free(buffer_);
 }
 
 bool FIFOChar::IsEmpty() {
   return avail_ == 0;
 }
 
 bool FIFOChar::IsFull() {
   return avail_ >= size_;
 }
 
 bool FIFOChar::Resize(size_t len) {
   // Can not resize smaller than the current size
   if (len < avail_)
     return false;
 
-  // Read current data into new buffer
-  char* data = new char[len];
-  avail_ = Read(data, avail_);
-
-  // Replace buffer
-  delete[] buffer_;
-  buffer_ = data;
+  // Resize buffer
+  buffer_ = (char*)realloc(buffer_, len);
   size_ = len;
   return true;
 }
 
 size_t FIFOChar::ReadAvailable() {
   return avail_;
 }
 
 size_t FIFOChar::WriteAvailable() {
   return size_ - avail_;
@@ skipping 50 matching lines @@
 
     out += write_len;
     len -= write_len;
   }
 
   avail_ += out;
   return out;
 }
 
 }  // namespace nacl_io