[NaCl SDK] nacl_io: Remove use of new/delete for data buffers.

native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#ifndef __STDC_LIMIT_MACROS
+#define __STDC_LIMIT_MACROS
+#endif
+
 #include "nacl_io/memfs/mem_fs_node.h"
 
+#include <assert.h>
 #include <errno.h>
 #include <string.h>
 
 #include <algorithm>
 
 #include "nacl_io/kernel_handle.h"
 #include "nacl_io/osstat.h"
 #include "sdk_util/auto_lock.h"
 
 namespace nacl_io {
 
 namespace {
 
 // The maximum size to reserve in addition to the requested size. Resize() will
 // allocate twice as much as requested, up to this value.
 const size_t kMaxResizeIncrement = 16 * 1024 * 1024;
 
 }  // namespace
 
-MemFsNode::MemFsNode(Filesystem* filesystem) : Node(filesystem) {
+MemFsNode::MemFsNode(Filesystem* filesystem)
+  : Node(filesystem),
+    data_(NULL),
+    data_capacity_(0) {
   SetType(S_IFREG);
 }
 
 MemFsNode::~MemFsNode() {
 }
 
 Error MemFsNode::Read(const HandleAttr& attr,
                       void* buf,
                       size_t count,
                       int* out_bytes) {
   *out_bytes = 0;
 
   AUTO_LOCK(node_lock_);
   if (count == 0)
     return 0;
 
   size_t size = stat_.st_size;
 
   if (attr.offs + count > size) {
     count = size - attr.offs;
   }
 
-  memcpy(buf, &data_[attr.offs], count);
+  memcpy(buf, data_ + attr.offs, count);
   *out_bytes = static_cast<int>(count);
   return 0;
 }
 
 Error MemFsNode::Write(const HandleAttr& attr,
                        const void* buf,
                        size_t count,
                        int* out_bytes) {
   *out_bytes = 0;
-  AUTO_LOCK(node_lock_);
 
   if (count == 0)
     return 0;
 
-  if (count + attr.offs > static_cast<size_t>(stat_.st_size)) {
-    Resize(count + attr.offs);
-    count = stat_.st_size - attr.offs;
+  AUTO_LOCK(node_lock_);
+  off_t new_size = attr.offs + count;
+  if (new_size > stat_.st_size) {
+    Error error = Resize(new_size);
+    if (error) {
+      LOG_ERROR("memfs: resize %ld failed: %s", new_size, strerror(error));

[binji, 2014/08/07 15:22:32]

Looks like you need a special macro for off_t?

memfs/mem_fs_node.cc:76:49: error: format specifies type 'long' but the argument
has type 'off_t' (aka 'long long') [-Werror,-Wformat]
      LOG_ERROR("memfs: resize %ld failed: %s", new_size, strerror(error));
                               ~~~              ^~~~~~~~
                               %lld

+      return error;
+    }
   }
 
-  memcpy(&data_[attr.offs], buf, count);
+  memcpy(data_ + attr.offs, buf, count);
   *out_bytes = static_cast<int>(count);
   return 0;
 }
 
 Error MemFsNode::FTruncate(off_t new_size) {
   AUTO_LOCK(node_lock_);
-  Resize(new_size);
+  return Resize(new_size);
+}
+
+Error MemFsNode::Resize(off_t new_length) {
+  if (new_length < 0)
+    return EINVAL;
+  size_t new_size = static_cast<size_t>(new_length);
+
+  if (new_size > data_capacity_) {
+    // While the node size is small, grow exponentially. When it starts to get
+    // larger, grow linearly.
+    size_t extra = std::min(new_size, kMaxResizeIncrement);
+    data_capacity_ = new_size + extra;
+  } else {
+    data_capacity_ = new_size;
+  }
+
+  data_ = (char*)realloc(data_, data_capacity_);
+  if (data_capacity_ != 0) {
+    assert(data_ != NULL);
+    if (data_ == NULL)
+      return ENOMEM;
+    if (new_length > stat_.st_size)
+      memset(data_ + stat_.st_size, 0, new_length - stat_.st_size);
+  }
+
+  stat_.st_size = new_length;
   return 0;
 }
 
-void MemFsNode::Resize(off_t new_size) {
-  if (new_size > static_cast<off_t>(data_.capacity())) {
-    // While the node size is small, grow exponentially. When it starts to get
-    // larger, grow linearly.
-    size_t extra = std::min<size_t>(new_size, kMaxResizeIncrement);
-    data_.reserve(new_size + extra);
-  } else if (new_size < stat_.st_size) {
-    // Shrink to fit. std::vector usually doesn't reduce allocation size, so
-    // use the swap trick.
-    std::vector<char>(data_).swap(data_);
-  }
-  data_.resize(new_size);
-  stat_.st_size = new_size;
-}
-
 }  // namespace nacl_io