Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 443673002: Make "Join other network dialog" and "Join mobile network dialog" opens properly on multiple signin… (Closed)

Created:
6 years, 4 months ago by Roman Sorokin (ftl)
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make "Join other network dialog" and "Join mobile network dialog" opens properly on multiple signin screen BUG=397100 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289496

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Roman Sorokin (ftl)
+oshima@ oshima@, please review
6 years, 4 months ago (2014-08-13 16:16:03 UTC) #1
oshima
lgtm
6 years, 4 months ago (2014-08-13 16:52:03 UTC) #2
Roman Sorokin (ftl)
The CQ bit was checked by rsorokin@chromium.org
6 years, 4 months ago (2014-08-13 17:17:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsorokin@chromium.org/443673002/20001
6 years, 4 months ago (2014-08-13 17:17:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 23:21:55 UTC) #5
Roman Sorokin (ftl)
The CQ bit was unchecked by rsorokin@chromium.org
6 years, 4 months ago (2014-08-14 08:13:13 UTC) #6
Roman Sorokin (ftl)
The CQ bit was checked by rsorokin@chromium.org
6 years, 4 months ago (2014-08-14 08:13:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsorokin@chromium.org/443673002/20001
6 years, 4 months ago (2014-08-14 08:15:17 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 08:53:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289496

Powered by Google App Engine
This is Rietveld 408576698