Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index ee1194ef75b33ada1fd65868cacc5a35ac2f400c..9d0b34235f22edee8d6260a63df88d3164c2dff9 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -123,13 +123,11 @@ class CONTENT_EXPORT ServiceWorkerVersion
void StartWorker(const StatusCallback& callback);
// Starts an embedded worker for this version.
- // |potential_process_ids| is a list of processes in which to start the
- // worker.
+ // |pause_after_download| notifies worker to pause after download finished
+ // which could be resumed by EmbeddedWorkerInstance::ResumeAfterDownload.
// This returns OK (success) if the worker is already running.
- void StartWorkerWithCandidateProcesses(
- const std::vector<int>& potential_process_ids,
- bool pause_after_download,
- const StatusCallback& callback);
+ void StartWorker(bool pause_after_download,
+ const StatusCallback& callback);
// Stops an embedded worker for this version.
// This returns OK (success) if the worker is already stopped.
@@ -199,22 +197,11 @@ class CONTENT_EXPORT ServiceWorkerVersion
void DispatchPushEvent(const StatusCallback& callback,
const std::string& data);
- // These are expected to be called when a renderer process host for the
- // same-origin as for this ServiceWorkerVersion is created. The added
- // processes are used to run an in-renderer embedded worker.
- void AddProcessToWorker(int process_id);
- void RemoveProcessFromWorker(int process_id);
-
- // Returns true if this has at least one process to run.
- bool HasProcessToRun() const;
-
// Adds and removes |provider_host| as a controllee of this ServiceWorker.
// A potential controllee is a host having the version as its .installing
// or .waiting version.
void AddControllee(ServiceWorkerProviderHost* provider_host);
void RemoveControllee(ServiceWorkerProviderHost* provider_host);
- void AddPotentialControllee(ServiceWorkerProviderHost* provider_host);
- void RemovePotentialControllee(ServiceWorkerProviderHost* provider_host);
// Returns if it has controllee.
bool HasControllee() const { return !controllee_map_.empty(); }

Powered by Google App Engine
This is Rietveld 408576698