Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 6a6134a1472ba111ccd064d7da378ebe2ecdddf6..3b33176be3a54ec3279a47fb5537fa1e53e0d737 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -85,6 +85,10 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
// Clears the associated registration and stop listening to it.
void UnassociateRegistration();
+ // Associates to |registration| then this provider can provide running
dominicc (has gone to gerrit) 2014/09/03 17:49:59 This comment needs work.
xiang 2014/09/04 09:18:36 Done.
+ // process for it. These registrations will be released in destructor.
+ void AssociatePendingRegistration(ServiceWorkerRegistration* registration);
+
// Returns false if the version is not in the expected STARTING in our
// process state. That would be indicative of a bad IPC message.
bool SetHostedVersionId(int64 versions_id);
@@ -122,13 +126,6 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
virtual void OnRegistrationFailed(
ServiceWorkerRegistration* registration) OVERRIDE;
- // Adds this provider host to the potential controllee list of the given
- // versions and removes it from the previous versions.
- void UpdatePotentialControllees(
- ServiceWorkerVersion* installing_version,
- ServiceWorkerVersion* waiting_version,
- ServiceWorkerVersion* active_version);
-
// Sets the controller version field to |version| or if |version| is NULL,
// clears the field.
void SetControllerVersionAttribute(ServiceWorkerVersion* version);
@@ -138,11 +135,16 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
// provider is responsible for releasing the handle.
ServiceWorkerObjectInfo CreateHandleAndPass(ServiceWorkerVersion* version);
+ // Increase/Decrease corresponding process reference for process manager.
+ void IncreaseProcessReference(ServiceWorkerRegistration* registration);
+ void DecreaseProcessReference(ServiceWorkerRegistration* registration);
+
const int process_id_;
const int provider_id_;
GURL document_url_;
scoped_refptr<ServiceWorkerRegistration> associated_registration_;
+ std::vector<scoped_refptr<ServiceWorkerRegistration> > pending_registrations_;
michaeln 2014/09/04 01:26:32 can this be a collection of GURL patterns so this
xiang 2014/09/04 09:18:36 Done.
scoped_refptr<ServiceWorkerVersion> controlling_version_;
scoped_refptr<ServiceWorkerVersion> active_version_;

Powered by Google App Engine
This is Rietveld 408576698