Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_register_job.h
diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h
index 7153fa1547be448259dba5dc8f146783d9d5b07b..c281ed2227ce917fa46a84a6943c99f5ca47df47 100644
--- a/content/browser/service_worker/service_worker_register_job.h
+++ b/content/browser/service_worker/service_worker_register_job.h
@@ -55,11 +55,11 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,
virtual ~ServiceWorkerRegisterJob();
// Registers a callback to be called when the promise would resolve (whether
- // successfully or not). Multiple callbacks may be registered. If |process_id|
- // is not -1, it's added to the existing clients when deciding in which
- // process to create the Service Worker instance. If there are no existing
- // clients, a new RenderProcessHost will be created.
- void AddCallback(const RegistrationCallback& callback, int process_id);
+ // successfully or not). Multiple callbacks may be registered.
+ // If |provider_host| is not NULL, its process will be regarded as a candidate
+ // process to run the worker.
+ void AddCallback(const RegistrationCallback& callback,
+ ServiceWorkerProviderHost* provider_host);
// ServiceWorkerRegisterJobBase implementation:
virtual void Start() OVERRIDE;
@@ -158,7 +158,6 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,
const GURL pattern_;
const GURL script_url_;
std::vector<RegistrationCallback> callbacks_;
- std::vector<int> pending_process_ids_;
Phase phase_;
Internal internal_;
bool is_promise_resolved_;

Powered by Google App Engine
This is Rietveld 408576698