Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: content/browser/service_worker/embedded_worker_instance_unittest.cc

Issue 443593002: ServiceWorker: Move worker candidate process knowledge to ServiceWorkerProcessManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance_unittest.cc
diff --git a/content/browser/service_worker/embedded_worker_instance_unittest.cc b/content/browser/service_worker/embedded_worker_instance_unittest.cc
index d651173614b7989b61550af4a51252694b0307d8..c66eb48468e2cedc87662b0677a4933a5d1e887e 100644
--- a/content/browser/service_worker/embedded_worker_instance_unittest.cc
+++ b/content/browser/service_worker/embedded_worker_instance_unittest.cc
@@ -60,13 +60,12 @@ TEST_F(EmbeddedWorkerInstanceTest, StartAndStop) {
embedded_worker_registry()->CreateWorker();
EXPECT_EQ(EmbeddedWorkerInstance::STOPPED, worker->status());
- const int embedded_worker_id = worker->embedded_worker_id();
const int64 service_worker_version_id = 55L;
const GURL scope("http://example.com/*");
const GURL url("http://example.com/worker.js");
- // Simulate adding one process to the worker.
- helper_->SimulateAddProcessToWorker(embedded_worker_id, kRenderProcessId);
+ // Simulate adding one process to the scope.
+ helper_->SimulateAddProcessToScope(scope, kRenderProcessId);
// Start should succeed.
ServiceWorkerStatusCode status;
@@ -76,7 +75,6 @@ TEST_F(EmbeddedWorkerInstanceTest, StartAndStop) {
scope,
url,
false,
- std::vector<int>(),
base::Bind(&SaveStatusAndCall, &status, run_loop.QuitClosure()));
run_loop.Run();
EXPECT_EQ(SERVICE_WORKER_OK, status);
@@ -116,12 +114,13 @@ TEST_F(EmbeddedWorkerInstanceTest, InstanceDestroyedBeforeStartFinishes) {
// Begin starting the worker.
std::vector<int> available_process;
available_process.push_back(kRenderProcessId);
+ context()->process_manager()->AddScopePendingProcesses(
+ scope, available_process);
worker->Start(
service_worker_version_id,
scope,
url,
false,
- available_process,
base::Bind(&SaveStatusAndCall, &status, run_loop.QuitClosure()));
// But destroy it before it gets a chance to complete.
worker.reset();
@@ -133,38 +132,4 @@ TEST_F(EmbeddedWorkerInstanceTest, InstanceDestroyedBeforeStartFinishes) {
ipc_sink()->GetUniqueMessageMatching(EmbeddedWorkerMsg_StartWorker::ID));
}
-TEST_F(EmbeddedWorkerInstanceTest, SortProcesses) {
- scoped_ptr<EmbeddedWorkerInstance> worker =
- embedded_worker_registry()->CreateWorker();
- EXPECT_EQ(EmbeddedWorkerInstance::STOPPED, worker->status());
-
- // Simulate adding processes to the worker.
- // Process 1 has 1 ref, 2 has 2 refs and 3 has 3 refs.
- const int embedded_worker_id = worker->embedded_worker_id();
- helper_->SimulateAddProcessToWorker(embedded_worker_id, 1);
- helper_->SimulateAddProcessToWorker(embedded_worker_id, 2);
- helper_->SimulateAddProcessToWorker(embedded_worker_id, 2);
- helper_->SimulateAddProcessToWorker(embedded_worker_id, 3);
- helper_->SimulateAddProcessToWorker(embedded_worker_id, 3);
- helper_->SimulateAddProcessToWorker(embedded_worker_id, 3);
-
- // Process 3 has the biggest # of references and it should be chosen.
- EXPECT_THAT(worker->SortProcesses(std::vector<int>()),
- testing::ElementsAre(3, 2, 1));
- EXPECT_EQ(-1, worker->process_id());
-
- // Argument processes are added to the existing set, but only for a single
- // call.
- std::vector<int> registering_processes;
- registering_processes.push_back(1);
- registering_processes.push_back(1);
- registering_processes.push_back(1);
- registering_processes.push_back(4);
- EXPECT_THAT(worker->SortProcesses(registering_processes),
- testing::ElementsAre(1, 3, 2, 4));
-
- EXPECT_THAT(worker->SortProcesses(std::vector<int>()),
- testing::ElementsAre(3, 2, 1));
-}
-
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698