Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issue 443573004: Stop setting AcceleratedCompositingForVideoEnabled in LayoutTests. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
palmer, piman
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, jochen+watch_chromium.org, creis+watch_chromium.org, enne (OOO)
Project:
chromium
Visibility:
Public.

Description

Stop setting AcceleratedCompositingForVideoEnabled in LayoutTests. This removes the setting entirely since it's always true in production. Once we stop setting it, we can remove it from blink. BUG=365857 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/common/webkit_test_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
piman: please review removing code. kenrb: security review, removing a parameter.
6 years, 4 months ago (2014-08-05 16:01:29 UTC) #1
piman
lgtm
6 years, 4 months ago (2014-08-05 17:29:32 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-05 20:47:25 UTC) #3
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 4 months ago (2014-08-05 20:47:34 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-05 20:47:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/443573004/1
6 years, 4 months ago (2014-08-05 20:49:21 UTC) #6
palmer
lgtm
6 years, 4 months ago (2014-08-05 20:56:42 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-06 00:55:54 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:08:58 UTC) #9
Message was sent while issue was closed.
Change committed as 287699

Powered by Google App Engine
This is Rietveld 408576698