[GCM] Adding status to AccountMapping structure

[GCM] Adding status to AccountMapping structure

* Renaming AccountInfo to AccountMapping.
* Adding status and timestamp of it's last change
* Removing last message timestamp, as with introduction of
  message ack event, it is no longer needed

BUG=374969
R=zea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287919

[fgorski, 2014-08-06 18:26:55]

Nicolas,
PTAL.

I applied all of the changes we discussed yesterday and then renamed the
structure and files.

[Nicolas Zea, 2014-08-06 19:10:12]

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
File google_apis/gcm/engine/account_mapping.h (right):

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
google_apis/gcm/engine/account_mapping.h:54: // Status of the account mapping.
Aren't we not going to persist the mapping status as well? (i.e. in memory only)

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
File google_apis/gcm/engine/account_mapping_unittest.cc (right):

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
google_apis/gcm/engine/account_mapping_unittest.cc:7: #include
"google_apis/gcm/engine/account_mapping.h"
nit: this is typically the first include in the file, as it's the file being
tested.

[fgorski, 2014-08-06 20:44:44]

Updated. Status will be inferred from the other fields when reading.

I'd rather fix it here than in GCMAccountMapper, because I still want to use the
field and have to set it to something reasonable. But as we discussed, it didn't
need to be persisted.

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
File google_apis/gcm/engine/account_mapping.h (right):

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
google_apis/gcm/engine/account_mapping.h:54: // Status of the account mapping.
On 2014/08/06 19:10:12, Nicolas Zea wrote:
> Aren't we not going to persist the mapping status as well? (i.e. in memory
only)

Done.

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
File google_apis/gcm/engine/account_mapping_unittest.cc (right):

https://codereview.chromium.org/443573002/diff/80001/google_apis/gcm/engine/a...
google_apis/gcm/engine/account_mapping_unittest.cc:7: #include
"google_apis/gcm/engine/account_mapping.h"
On 2014/08/06 19:10:12, Nicolas Zea wrote:
> nit: this is typically the first include in the file, as it's the file being
> tested.

Done.

[Nicolas Zea, 2014-08-06 20:46:46]

lgtm

[fgorski, 2014-08-06 20:52:13]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2014-08-06 20:52:19]

The CQ bit was unchecked by fgorski@chromium.org

[fgorski, 2014-08-06 20:52:23]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-08-06 20:55:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/443573002/100001

[commit-bot: I haz the power, 2014-08-07 00:45:38]

Change committed as 287919