Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/resources/help/help_page.js

Issue 443553002: Typecheck chrome://help using CompilerPass.java, everything except dependency to options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master
Patch Set: fixed one nit Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('help', function() { 5 cr.define('help', function() {
6 var Page = cr.ui.pageManager.Page; 6 var Page = cr.ui.pageManager.Page;
7 var PageManager = cr.ui.pageManager.PageManager; 7 var PageManager = cr.ui.pageManager.PageManager;
8 8
9 /** 9 /**
10 * Encapsulated handling of the About page. Called 'help' internally to avoid 10 * Encapsulated handling of the About page. Called 'help' internally to avoid
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 * @private 180 * @private
181 */ 181 */
182 toggleMoreInfo_: function() { 182 toggleMoreInfo_: function() {
183 var moreInfo = $('more-info-container'); 183 var moreInfo = $('more-info-container');
184 this.setMoreInfoVisible_(!moreInfo.classList.contains('visible')); 184 this.setMoreInfoVisible_(!moreInfo.classList.contains('visible'));
185 }, 185 },
186 186
187 /** 187 /**
188 * Assigns |method| to the onclick property of |el| if |el| exists. 188 * Assigns |method| to the onclick property of |el| if |el| exists.
189 * @param {HTMLElement} el The element on which to set the click handler. 189 * @param {HTMLElement} el The element on which to set the click handler.
190 * @param {function} method The click handler. 190 * @param {Function} method The click handler.
191 * @private 191 * @private
192 */ 192 */
193 maybeSetOnClick_: function(el, method) { 193 maybeSetOnClick_: function(el, method) {
194 if (el) 194 if (el)
195 el.onclick = method; 195 el.onclick = method;
196 }, 196 },
197 197
198 /** 198 /**
199 * @param {string} state The state of the update. 199 * @param {string} state The state of the update.
200 * private 200 * private
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
555 555
556 HelpPage.updateChannelChangePageContainerVisibility = function() { 556 HelpPage.updateChannelChangePageContainerVisibility = function() {
557 HelpPage.getInstance().updateChannelChangePageContainerVisibility_(); 557 HelpPage.getInstance().updateChannelChangePageContainerVisibility_();
558 }; 558 };
559 559
560 // Export 560 // Export
561 return { 561 return {
562 HelpPage: HelpPage 562 HelpPage: HelpPage
563 }; 563 };
564 }); 564 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698