Remove TraceOptions string based constructor.

base/debug/trace_event_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/trace_event_impl.h"
 
 #include <algorithm>
 
 #include "base/base_switches.h"
 #include "base/bind.h"
@@ skipping 966 matching lines @@
 
 TraceBucketData::~TraceBucketData() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // TraceOptions
 //
 ////////////////////////////////////////////////////////////////////////////////
 
-TraceOptions::TraceOptions(const std::string& options_string)
-    : record_mode(RECORD_UNTIL_FULL),
-      enable_sampling(false),
-      enable_systrace(false) {
+bool TraceOptions::SetFromString(const std::string& options_string) {
+  record_mode = RECORD_UNTIL_FULL;
+  enable_sampling = false;
+  enable_systrace = false;
+
   std::vector<std::string> split;
   std::vector<std::string>::iterator iter;
-
   base::SplitString(options_string, ',', &split);
   for (iter = split.begin(); iter != split.end(); ++iter) {
     if (*iter == kRecordUntilFull) {
       record_mode = RECORD_UNTIL_FULL;
     } else if (*iter == kRecordContinuously) {
       record_mode = RECORD_CONTINUOUSLY;
     } else if (*iter == kTraceToConsole) {
       record_mode = ECHO_TO_CONSOLE;
     } else if (*iter == kRecordAsMuchAsPossible) {
       record_mode = RECORD_AS_MUCH_AS_POSSIBLE;
     } else if (*iter == kEnableSampling) {
       enable_sampling = true;
     } else if (*iter == kEnableSystrace) {
       enable_systrace = true;
     } else {
-      NOTREACHED();
+      return false;
     }
   }
+  return true;
 }
 
 std::string TraceOptions::ToString() const {
   std::string ret;
   switch (record_mode) {
     case RECORD_UNTIL_FULL:
       ret = kRecordUntilFull;
       break;
     case RECORD_CONTINUOUSLY:
       ret = kRecordContinuously;
@@ skipping 1539 matching lines @@
 }
 
 ScopedTraceBinaryEfficient::~ScopedTraceBinaryEfficient() {
   if (*category_group_enabled_) {
     TRACE_EVENT_API_UPDATE_TRACE_EVENT_DURATION(category_group_enabled_,
                                                 name_, event_handle_);
   }
 }
 
 }  // namespace trace_event_internal