Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2143)

Unified Diff: base/compiler_specific.h

Issue 443483002: Use a C++11 feature in a single file, to discover if this works everywhere. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/compiler_specific.h
diff --git a/base/compiler_specific.h b/base/compiler_specific.h
index 9e2111db6b6e1aea9aa59beb96047c3c3ef2c3eb..a93d350aae0999964bf29c30b58469a728aa2ac9 100644
--- a/base/compiler_specific.h
+++ b/base/compiler_specific.h
@@ -137,30 +137,14 @@
// method in the parent class.
// Use like:
// virtual void foo() OVERRIDE;
-#if defined(__clang__) || defined(COMPILER_MSVC)
#define OVERRIDE override
-#elif defined(COMPILER_GCC) && __cplusplus >= 201103 && \
- (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700
-// GCC 4.7 supports explicit virtual overrides when C++11 support is enabled.
-#define OVERRIDE override
-#else
-#define OVERRIDE
-#endif
// Annotate a virtual method indicating that subclasses must not override it,
// or annotate a class to indicate that it cannot be subclassed.
// Use like:
// virtual void foo() FINAL;
// class B FINAL : public A {};
-#if defined(__clang__) || defined(COMPILER_MSVC)
#define FINAL final
-#elif defined(COMPILER_GCC) && __cplusplus >= 201103 && \
- (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700
-// GCC 4.7 supports explicit virtual overrides when C++11 support is enabled.
-#define FINAL final
-#else
-#define FINAL
-#endif
// Annotate a function indicating the caller must examine the return value.
// Use like:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698