Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 443453002: libxml.gyp: remove clang-on-windows specific option (Closed)

Created:
6 years, 4 months ago by hans
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

libxml.gyp: remove clang-on-windows specific option The /U__STDC_VERSION__ option was necessary when using VS2012 headers, which didn't include nan(), but we're on 2013 now. BUG=82385 TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M third_party/libxml/libxml.gyp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Please take a look.
6 years, 4 months ago (2014-08-04 16:48:26 UTC) #1
Nico
lgtm!
6 years, 4 months ago (2014-08-04 16:56:13 UTC) #2
hans
The CQ bit was checked by hans@chromium.org
6 years, 4 months ago (2014-08-04 16:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/443453002/1
6 years, 4 months ago (2014-08-04 17:00:09 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:13:12 UTC) #5
Message was sent while issue was closed.
Change committed as 287415

Powered by Google App Engine
This is Rietveld 408576698