Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 443443002: [Telemetry]: Add --target-arch option to browser options. (Closed)

Created:
6 years, 4 months ago by rmcilroy
Modified:
6 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Telemetry]: Add --target-arch option to browser options. Add a --target-arch argument to the browser finder options. This is used by the backend to pass the correct arch to the stack symbolization script on crashes. BUG=399896, 385125 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287413

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add options to target-arch help #

Total comments: 2

Patch Set 3 : Add space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 3 chunks +6 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rmcilroy
Sami, could you please take a look, thanks.
6 years, 4 months ago (2014-08-04 15:09:55 UTC) #1
Sami
Thanks Ross, lgtm with a tiny nit. https://codereview.chromium.org/443443002/diff/1/tools/telemetry/telemetry/core/browser_options.py File tools/telemetry/telemetry/core/browser_options.py (right): https://codereview.chromium.org/443443002/diff/1/tools/telemetry/telemetry/core/browser_options.py#newcode81 tools/telemetry/telemetry/core/browser_options.py:81: help='The target ...
6 years, 4 months ago (2014-08-04 15:26:02 UTC) #2
rmcilroy
https://codereview.chromium.org/443443002/diff/1/tools/telemetry/telemetry/core/browser_options.py File tools/telemetry/telemetry/core/browser_options.py (right): https://codereview.chromium.org/443443002/diff/1/tools/telemetry/telemetry/core/browser_options.py#newcode81 tools/telemetry/telemetry/core/browser_options.py:81: help='The target architecture of the browser.' On 2014/08/04 15:26:02, ...
6 years, 4 months ago (2014-08-04 16:21:20 UTC) #3
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 4 months ago (2014-08-04 16:21:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/443443002/20001
6 years, 4 months ago (2014-08-04 16:22:36 UTC) #5
Sami
https://codereview.chromium.org/443443002/diff/20001/tools/telemetry/telemetry/core/browser_options.py File tools/telemetry/telemetry/core/browser_options.py (right): https://codereview.chromium.org/443443002/diff/20001/tools/telemetry/telemetry/core/browser_options.py#newcode82 tools/telemetry/telemetry/core/browser_options.py:82: 'x64, x86_64, arm, arm64 and mips.' Another space missing ...
6 years, 4 months ago (2014-08-04 17:14:37 UTC) #6
rmcilroy
The CQ bit was unchecked by rmcilroy@chromium.org
6 years, 4 months ago (2014-08-04 17:18:54 UTC) #7
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 4 months ago (2014-08-04 17:26:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/443443002/40001
6 years, 4 months ago (2014-08-04 17:28:26 UTC) #9
rmcilroy
https://codereview.chromium.org/443443002/diff/20001/tools/telemetry/telemetry/core/browser_options.py File tools/telemetry/telemetry/core/browser_options.py (right): https://codereview.chromium.org/443443002/diff/20001/tools/telemetry/telemetry/core/browser_options.py#newcode82 tools/telemetry/telemetry/core/browser_options.py:82: 'x64, x86_64, arm, arm64 and mips.' On 2014/08/04 17:14:37, ...
6 years, 4 months ago (2014-08-04 22:10:40 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:11:37 UTC) #11
Message was sent while issue was closed. 
Change committed as 287413

Powered by Google App Engine
This is Rietveld 408576698