Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Issue 443433003: Use tighter typing in editing: SimplifyMarkupCommand & TextIterator (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Use tighter typing in editing: SimplifyMarkupCommand & TextIterator Use tighter typing in editing to increase code readability. This CL focuses on SimplifyMarkupCommand and TextIterator. R=yosin@chromium.org, leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -39 lines) Patch
M Source/core/editing/SimplifyMarkupCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SimplifyMarkupCommand.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/TextIterator.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 9 chunks +18 lines, -23 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Inactive
6 years, 4 months ago (2014-08-04 15:52:10 UTC) #1
leviw_travelin_and_unemployed
Nice. LGTM.
6 years, 4 months ago (2014-08-04 18:53:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/443433003/1
6 years, 4 months ago (2014-08-04 18:54:19 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-04 19:37:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 19:51:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20604)
6 years, 4 months ago (2014-08-04 19:51:01 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-04 19:58:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/443433003/1
6 years, 4 months ago (2014-08-04 19:59:43 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-04 20:42:07 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 21:21:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20625)
6 years, 4 months ago (2014-08-04 21:21:16 UTC) #11
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-04 23:30:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/443433003/1
6 years, 4 months ago (2014-08-04 23:31:46 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 00:11:47 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 01:12:17 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20683)
6 years, 4 months ago (2014-08-05 01:12:18 UTC) #16
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-05 13:06:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/443433003/1
6 years, 4 months ago (2014-08-05 13:09:03 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 14:37:36 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 16:06:58 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20966)
6 years, 4 months ago (2014-08-05 16:06:59 UTC) #21
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-05 19:07:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/443433003/1
6 years, 4 months ago (2014-08-05 19:09:18 UTC) #23
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 21:07:33 UTC) #24
Message was sent while issue was closed.
Change committed as 179525

Powered by Google App Engine
This is Rietveld 408576698