Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 44343002: Geolocation: expand number of buckets for wifi access points in histogram. (Closed)

Created:
7 years, 1 month ago by Michael van Ouwerkerk
Modified:
7 years, 1 month ago
Reviewers:
timvolodine
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Geolocation: expand number of buckets for wifi access points in histogram. The current histogram shows that 46% of the data ends up in the overflow bucket. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231095

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/geolocation/network_location_request.cc View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Michael van Ouwerkerk
tim as feature reviewer
7 years, 1 month ago (2013-10-25 13:42:12 UTC) #1
timvolodine
https://codereview.chromium.org/44343002/diff/1/content/browser/geolocation/network_location_request.cc File content/browser/geolocation/network_location_request.cc (right): https://codereview.chromium.org/44343002/diff/1/content/browser/geolocation/network_location_request.cc#newcode64 content/browser/geolocation/network_location_request.cc:64: const int buckets = 21; maybe add in the ...
7 years, 1 month ago (2013-10-25 13:45:54 UTC) #2
Michael van Ouwerkerk
Done, thanks :-) https://codereview.chromium.org/44343002/diff/1/content/browser/geolocation/network_location_request.cc File content/browser/geolocation/network_location_request.cc (right): https://codereview.chromium.org/44343002/diff/1/content/browser/geolocation/network_location_request.cc#newcode64 content/browser/geolocation/network_location_request.cc:64: const int buckets = 21; On ...
7 years, 1 month ago (2013-10-25 13:49:45 UTC) #3
timvolodine
lgtm cool thanks!
7 years, 1 month ago (2013-10-25 13:51:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/44343002/1
7 years, 1 month ago (2013-10-25 13:59:01 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 19:59:16 UTC) #6
Message was sent while issue was closed.
Change committed as 231095

Powered by Google App Engine
This is Rietveld 408576698