Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 443393002: Stop using WebMediaPlayerClient::preload() and volume() (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Stop using WebMediaPlayerClient::preload() and volume() There is a "FIXME: Remove once calls on the Chromium-side have been removed" for volume() in WebMediaPlayerClient.h. preload() is similarly strange layering-wise, so get rid of that as well. Simply store the values when they cannot immediately be forwarded to the internal object. In the case of WebMediaPlayerImpl::setVolume(), the value can always be used immediately, so the setVolume() in DoLoad() appears to simply have been unnecessary. BUG=401415 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL. I don't venture into Chromium very often so look out for newbie mistakes. I ...
6 years, 4 months ago (2014-08-07 11:09:59 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 4 months ago (2014-08-07 15:42:57 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-07 15:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/443393002/1
6 years, 4 months ago (2014-08-07 15:45:33 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:42:35 UTC) #5
Message was sent while issue was closed.
Change committed as 288080

Powered by Google App Engine
This is Rietveld 408576698