Refactor HttpStreamFactoryImpl::Job::DoCreateStream() for handling WebSocket correctly

Refactor HttpStreamFactoryImpl::Job::DoCreateStream() for handling WebSocket correctly

This function is long and sophisticated. Factor out the code creating
and setting |stream_| and reorganize if-clauses.

Then, this CL adds for_websockets_ checks where it's missing.

R=jgraettinger,rch
BUG=394434
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291131

[tyoshino (SeeGerritForStatus), 2014-08-07 16:40:27]

Not only refactoring, but this CL also adds for_websockets_ checks where it's
missing. Updated the CL description.

[Johnny, 2014-08-07 16:47:27]

lgtm, but +rch for another pair of eyes

[tyoshino (SeeGerritForStatus), 2014-08-07 17:03:37]

On 2014/08/07 16:47:27, Johnny wrote:
> lgtm, but +rch for another pair of eyes

Thanks. Ryan, another CL for this class is in CQ
https://codereview.chromium.org/440293003/
The CL replaces the NOTREACHED() at L1127 in the old snapshot to
ERR_NOT_IMPLEMENTED as on L1033 to L1036 in the new snapshot (ps2). This CL
includes the change.

[tyoshino (SeeGerritForStatus), 2014-08-18 04:31:34]

On 2014/08/07 17:03:37, tyoshino wrote:
> On 2014/08/07 16:47:27, Johnny wrote:
> > lgtm, but +rch for another pair of eyes
> 
> Thanks. Ryan, another CL for this class is in CQ
> https://codereview.chromium.org/440293003/
> The CL replaces the NOTREACHED() at L1127 in the old snapshot to
> ERR_NOT_IMPLEMENTED as on L1033 to L1036 in the new snapshot (ps2). This CL
> includes the change.

ping

[Johnny, 2014-08-19 15:50:13]

Ryan's rather busy, I gather :)

This still lgtm; go ahead and land it.

[Ryan Hamilton, 2014-08-19 16:36:52]

Gah! I'm very sorry for the delay. Yes, this LGTM.

[tyoshino (SeeGerritForStatus), 2014-08-21 14:40:21]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-08-21 14:41:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/443383002/40001

[commit-bot: I haz the power, 2014-08-21 18:07:40]

Committed patchset #3 (40001) as 291131