Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 443353003: cc: Switch some pixel tests to use impl-side painting. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, garykac, piman
Project:
chromium
Visibility:
Public.

Description

cc: Switch some pixel tests to use impl-side painting. These tests use ContentLayer, so change them to use PictureLayer instead and stop explicitly disabling impl-side painting. R=enne BUG=401492 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M cc/trees/layer_tree_host_pixeltest_readback.cc View 10 chunks +38 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
6 years, 4 months ago (2014-08-07 14:02:19 UTC) #1
danakj
I used​ FakePictureLayer here so we could verify the HighResTiling() on the impl-thread, but there's ...
6 years, 4 months ago (2014-08-07 14:04:54 UTC) #2
enne (OOO)
lgtm
6 years, 4 months ago (2014-08-07 17:00:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/443353003/1
6 years, 4 months ago (2014-08-07 17:01:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 18:04:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 18:44:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/2543)
6 years, 4 months ago (2014-08-07 18:44:55 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-07 23:37:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/443353003/1
6 years, 4 months ago (2014-08-08 00:00:44 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 08:03:33 UTC) #10
Message was sent while issue was closed.
Change committed as 288244

Powered by Google App Engine
This is Rietveld 408576698