Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 443293003: Mojo: Add PRESUBMIT.py to mojo/. (Closed)

Created:
6 years, 4 months ago by viettrungluu
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Add PRESUBMIT.py to mojo/. Currently, it only adds pylint checks, with a blacklist for all the files that fail horribly (or in otherwise mysterious ways). Also fix a few (less mysterious) pylint failures. Remove some pylint suppressions (since we now add appropriate directories to the python module path for pylint). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -50 lines) Patch
A mojo/PRESUBMIT.py View 1 chunk +37 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/data.py View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/lexer.py View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 2 chunks +2 lines, -7 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/translate.py View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/ast_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/lexer_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/run_parser.py View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/run_translate.py View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/support/find_files.py View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/tools/generate_java_callback_interfaces.py View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 4 months ago (2014-08-06 22:58:38 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-06 23:02:42 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 4 months ago (2014-08-06 23:07:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/443293003/1
6 years, 4 months ago (2014-08-06 23:11:49 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 07:28:15 UTC) #5
Message was sent while issue was closed. 
Change committed as 287988

Powered by Google App Engine
This is Rietveld 408576698