Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: ui/android/java/src/org/chromium/ui/DropdownAdapter.java

Issue 443193006: Show icons in Android web autofill dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix up build files Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/java/res/layout/dropdown_item.xml ('k') | ui/android/java/src/org/chromium/ui/DropdownItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/DropdownAdapter.java
diff --git a/ui/android/java/src/org/chromium/ui/DropdownAdapter.java b/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
index 2b561d19bd51378f6a5dea6ba6b8e747a3178cb5..051b83675969a93a3266cfbd19cc75a29f10d5a2 100644
--- a/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
+++ b/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
@@ -13,6 +13,7 @@ import android.view.View;
import android.view.ViewGroup;
import android.widget.AbsListView.LayoutParams;
import android.widget.ArrayAdapter;
+import android.widget.ImageView;
import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
@@ -62,18 +63,6 @@ public class DropdownAdapter extends ArrayAdapter<DropdownItem> {
ApiCompatibilityUtils.setBackgroundForView(layout, new DropdownDividerDrawable());
}
- DropdownItem item = getItem(position);
-
- TextView labelView = (TextView) layout.findViewById(R.id.dropdown_label);
- labelView.setText(item.getLabel());
-
- labelView.setEnabled(item.isEnabled());
- if (item.isGroupHeader()) {
- labelView.setTypeface(null, Typeface.BOLD);
- } else {
- labelView.setTypeface(null, Typeface.NORMAL);
- }
-
DropdownDividerDrawable divider = (DropdownDividerDrawable) layout.getBackground();
int height = mContext.getResources().getDimensionPixelSize(R.dimen.dropdown_item_height);
if (position == 0) {
@@ -93,6 +82,17 @@ public class DropdownAdapter extends ArrayAdapter<DropdownItem> {
}
layout.setLayoutParams(new LayoutParams(LayoutParams.MATCH_PARENT, height));
+ DropdownItem item = getItem(position);
+ TextView labelView = (TextView) layout.findViewById(R.id.dropdown_label);
+ labelView.setText(item.getLabel());
+
+ labelView.setEnabled(item.isEnabled());
+ if (item.isGroupHeader()) {
+ labelView.setTypeface(null, Typeface.BOLD);
+ } else {
+ labelView.setTypeface(null, Typeface.NORMAL);
+ }
+
TextView sublabelView = (TextView) layout.findViewById(R.id.dropdown_sublabel);
CharSequence sublabel = item.getSublabel();
if (TextUtils.isEmpty(sublabel)) {
@@ -102,6 +102,14 @@ public class DropdownAdapter extends ArrayAdapter<DropdownItem> {
sublabelView.setVisibility(View.VISIBLE);
}
+ ImageView iconView = (ImageView) layout.findViewById(R.id.dropdown_icon);
+ if (item.getIconId() == DropdownItem.NO_ICON) {
+ iconView.setVisibility(View.GONE);
+ } else {
+ iconView.setImageResource(item.getIconId());
+ iconView.setVisibility(View.VISIBLE);
+ }
+
return layout;
}
« no previous file with comments | « ui/android/java/res/layout/dropdown_item.xml ('k') | ui/android/java/src/org/chromium/ui/DropdownItem.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698