chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java - Issue 443193006: Show icons in Android web autofill dropdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

Issue 443193006: Show icons in Android web autofill dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: works Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/android/autofill/autofill_popup_view_android.cc » ('j') | chrome/browser/ui/android/autofill/autofill_popup_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

index 5865ff1c5cb7e320d906cea81a367a9056636621..bdc6822445ac7886e7cde774080ea8e537e5dc75 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

@@ -5,6 +5,7 @@

package org.chromium.chrome.browser.autofill;

import android.app.Activity;

+import android.graphics.Bitmap;

import android.os.Handler;

import org.chromium.base.CalledByNative;

@@ -105,8 +106,8 @@ public class AutofillPopupBridge implements AutofillPopupDelegate{

@CalledByNative

private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,

- String label, String sublabel, int uniqueId) {

- array[index] = new AutofillSuggestion(label, sublabel, uniqueId);

+ String label, String sublabel, Bitmap icon, int uniqueId) {

+ array[index] = new AutofillSuggestion(label, sublabel, icon, uniqueId);

}

private native void nativeRequestHide(long nativeAutofillPopupViewAndroid);