Show icons in Android web autofill dropdown

ui/android/java/res/layout/dropdown_item.xml

Index: ui/android/java/res/layout/dropdown_item.xml
diff --git a/ui/android/java/res/layout/dropdown_item.xml b/ui/android/java/res/layout/dropdown_item.xml
index bded0ad992682189db918912a3dfb442a160eaaa..704071837d420709a436fac133a63530f6b80c57 100644
--- a/ui/android/java/res/layout/dropdown_item.xml
+++ b/ui/android/java/res/layout/dropdown_item.xml
@@ -6,29 +6,48 @@
 -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:id="@+id/dropdown_menu_text"
-    android:orientation="vertical"
+    android:orientation="horizontal"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
     android:gravity="center_vertical">
 
-    <TextView android:id="@+id/dropdown_label"
+    <LinearLayout
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginStart="10dp"
-        android:layout_marginEnd="10dp"
-        android:ellipsize="end"
-        android:singleLine="true"
-        android:textAlignment="viewStart"
-        android:textSize="18sp"
-        android:includeFontPadding="false"/>
-    <TextView android:id="@+id/dropdown_sublabel"
+        android:orientation="vertical">
+
+        <TextView android:id="@+id/dropdown_label"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="10dp"
+            android:layout_marginEnd="10dp"
+            android:ellipsize="end"
+            android:singleLine="true"
+            android:textAlignment="viewStart"
+            android:textSize="18sp"
+            android:includeFontPadding="false"/>
+        <TextView android:id="@+id/dropdown_sublabel"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="10dp"
+            android:layout_marginEnd="10dp"
+            android:textSize="14sp"
+            android:textColor="#8b8b8b"
+            android:ellipsize="end"
+            android:singleLine="true"
+            android:textAlignment="viewStart"
+            android:includeFontPadding="false"/>
+    </LinearLayout>
+
+    <!-- Spacer to move the icon to the right. -->

[aurimas (slooooooooow), 2014/11/04 21:17:39]

Why don't we simply make the linear layout that contains the text views expand?
Then we dont have this spacer view.

[Evan Stade, 2014/11/04 22:09:41]

good idea, done.

+    <View
+        android:layout_width="0dp"
+        android:layout_height="0dp"
+        android:layout_weight="1"/>
+
+    <ImageView android:id="@+id/dropdown_icon"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginStart="10dp"
-        android:layout_marginEnd="10dp"
-        android:textSize="14sp"
-        android:textColor="#8b8b8b"
-        android:ellipsize="end"
-        android:singleLine="true"
-        android:textAlignment="viewStart"
-        android:includeFontPadding="false"/>
+        android:layout_margin="8dp"/>
+
 </LinearLayout>