Show icons in Android web autofill dropdown

chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/autofill/autofill_popup_view_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "chrome/browser/ui/android/window_android_helper.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "jni/AutofillPopupBridge_jni.h"
 #include "ui/base/android/view_android.h"
 #include "ui/base/android/window_android.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/rect.h"
 
 namespace autofill {
 
 AutofillPopupViewAndroid::AutofillPopupViewAndroid(
     AutofillPopupController* controller)
     : controller_(controller) {}
 
 AutofillPopupViewAndroid::~AutofillPopupViewAndroid() {}
 
@@ skipping 33 matching lines @@
 
   ScopedJavaLocalRef<jobjectArray> data_array =
       Java_AutofillPopupBridge_createAutofillSuggestionArray(env, count);
 
   for (size_t i = 0; i < count; ++i) {
     ScopedJavaLocalRef<jstring> name =
         base::android::ConvertUTF16ToJavaString(env, controller_->names()[i]);
     ScopedJavaLocalRef<jstring> subtext =
         base::android::ConvertUTF16ToJavaString(env,
                                                 controller_->subtexts()[i]);
+    ScopedJavaLocalRef<jobject> icon;
+    if (!controller_->icons()[i].empty()) {
+      int icon_id = controller_->GetIconResourceID(controller_->icons()[i]);
+      DCHECK_NE(-1, icon_id);
+      ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+      icon = gfx::ConvertToJavaBitmap(rb.GetImageNamed(icon_id).ToSkBitmap());

[aruslan, 2014/08/08 22:06:39]

1. Get all necessary resolutions for every image you need (MDPI, HDPI, XHDPI and
XXHDPI) and place them to e.g. chrome/android/java/res

E.g. chrome/android/java/res/drawable-hdpi/abc_visa_card_image.png

2. Add all relevant mappings to chrome/browser/android/resource_id.h
E.g.
DEFINE_RESOURCE_ID(IDR_ABC_VISA_CARD_IMAGE, R.drawable.abc_visa_card_image)

3. In the autofill_popup_view_android.cc instead of rb.GetImageNamed(icon_id)
use

#include "chrome/browser/android/resource_mapper.h"
ResourceMapper::MapFromChromiumId(icon_id)

4. ...
5. PROFIT!!!

+    }
+
     Java_AutofillPopupBridge_addToAutofillSuggestionArray(
         env,
         data_array.obj(),
         i,
         name.obj(),
         subtext.obj(),
+        icon.obj(),
         controller_->identifiers()[i]);
   }
 
   Java_AutofillPopupBridge_show(
       env, java_object_.obj(), data_array.obj(), controller_->IsRTL());
 }
 
 void AutofillPopupViewAndroid::SuggestionSelected(JNIEnv* env,
                                                   jobject obj,
                                                   jint list_index) {
@@ skipping 11 matching lines @@
   return RegisterNativesImpl(env);
 }
 
 // static
 AutofillPopupView* AutofillPopupView::Create(
     AutofillPopupController* controller) {
   return new AutofillPopupViewAndroid(controller);
 }
 
 }  // namespace autofill