Issue 443183003: Respect output_all_resource_defines when generating structures in resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 443183003: Respect output_all_resource_defines when generating structures in resource (Closed)

Created:
6 years, 4 months ago by tony

Modified:
6 years, 4 months ago

Reviewers:

CC:
grit-developer_googlegroups.com

Base URL:
http://grit-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

Respect output_all_resource_defines when generating structures in resource maps. BUG=chromium:333201 TEST=included unit test. Original patch by Lei Zhang at: https://codereview.chromium.org/444053003/ Committed: https://code.google.com/p/grit-i18n/source/detail?r=172

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -11 lines)			Patch
M	grit/format/resource_map.py	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	grit/format/resource_map_unittest.py	View	1 chunk	+59 lines, -0 lines	0 comments	Download
M	grit/node/base.py	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	grit/node/include.py	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	grit/node/message.py	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	grit/node/structure.py	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

tony

6 years, 4 months ago (2014-08-06 21:54:36 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r172 (presubmit successful).