Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 443163002: Rename WallpaperInfo::file --> WallpaperInfo::location. (Closed)

Created:
6 years, 4 months ago by Thiemo Nagel
Modified:
6 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename WallpaperInfo::file --> WallpaperInfo::location. I consider "file" somewhat misleading since the field either contains a path segment (file name plus lowermost directory) or an URL. TBR=bshe@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 18 chunks +21 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Thiemo Nagel
Hi Pavel, could you please take a look? Thank you! Thiemo
6 years, 4 months ago (2014-08-06 17:29:07 UTC) #1
dzhioev (left Google)
On 2014/08/06 17:29:07, Thiemo Nagel wrote: > Hi Pavel, > > could you please take ...
6 years, 4 months ago (2014-08-07 08:32:00 UTC) #2
Thiemo Nagel
On 2014/08/07 08:32:00, dzhioev wrote: > On 2014/08/06 17:29:07, Thiemo Nagel wrote: > > Hi ...
6 years, 4 months ago (2014-08-07 08:35:51 UTC) #3
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 4 months ago (2014-08-07 08:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/443163002/1
6 years, 4 months ago (2014-08-07 08:36:42 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 10:02:02 UTC) #6
Message was sent while issue was closed. 
Change committed as 288020

Powered by Google App Engine
This is Rietveld 408576698