Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 443133002: Fix widget visibility accounting when crashing in background. (Closed)

Created:
6 years, 4 months ago by ppi
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Fix widget visibility accounting when crashing in background. RenderWidgetHostImpl tracks its visibility using the |is_hidden_| field. This value should be not be reset when the renderer crashes, otherwise a widget that crashes in backround will think it's already visible when put in foreground, messing up process visibility accounting. This patch fixes process visibility for processes that crashed in background and are respawned upon foregrounding by preserving the |is_hidden_| field through renderer crashes. BUG=399521 R=aelias@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
ppi
Hi Alexandre, ptal. Not sure what'd be a proper low-level test for this, but an ...
6 years, 4 months ago (2014-08-06 14:29:50 UTC) #1
ppi
PS the line being removed was introduced in the initial chromium commit, so no clue ...
6 years, 4 months ago (2014-08-06 16:54:02 UTC) #2
aelias_OOO_until_Jul13
lgtm
6 years, 4 months ago (2014-08-06 18:27:31 UTC) #3
ppi
Thanks!
6 years, 4 months ago (2014-08-06 18:33:47 UTC) #4
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 4 months ago (2014-08-06 18:33:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/443133002/1
6 years, 4 months ago (2014-08-06 18:37:21 UTC) #6
ppi
The CQ bit was unchecked by ppi@chromium.org
6 years, 4 months ago (2014-08-06 21:30:20 UTC) #7
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 4 months ago (2014-08-06 21:30:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/443133002/1
6 years, 4 months ago (2014-08-06 21:33:54 UTC) #9
ppi
6 years, 4 months ago (2014-08-06 21:38:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as 287864 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698