Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: src/arm/ic-arm.cc

Issue 44313002: Try to use STMDB/LDMIA instead of LDR/STR sequences whenever possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 __ LoadFromNumberDictionary(&slow_load, r4, r2, r1, r0, r3, r5); 570 __ LoadFromNumberDictionary(&slow_load, r4, r2, r1, r0, r3, r5);
571 __ IncrementCounter(counters->keyed_call_generic_smi_dict(), 1, r0, r3); 571 __ IncrementCounter(counters->keyed_call_generic_smi_dict(), 1, r0, r3);
572 __ jmp(&do_call); 572 __ jmp(&do_call);
573 573
574 __ bind(&slow_load); 574 __ bind(&slow_load);
575 // This branch is taken when calling KeyedCallIC_Miss is neither required 575 // This branch is taken when calling KeyedCallIC_Miss is neither required
576 // nor beneficial. 576 // nor beneficial.
577 __ IncrementCounter(counters->keyed_call_generic_slow_load(), 1, r0, r3); 577 __ IncrementCounter(counters->keyed_call_generic_slow_load(), 1, r0, r3);
578 { 578 {
579 FrameScope scope(masm, StackFrame::INTERNAL); 579 FrameScope scope(masm, StackFrame::INTERNAL);
580 __ push(r2); // save the key 580 __ Push(r2, r1); // save the key and the receiver
581 __ Push(r1, r2); // pass the receiver and the key 581 __ push(r2); // pass the receiver and the key
582 __ CallRuntime(Runtime::kKeyedGetProperty, 2); 582 __ CallRuntime(Runtime::kKeyedGetProperty, 2);
583 __ pop(r2); // restore the key 583 __ pop(r2); // restore the key
584 } 584 }
585 __ mov(r1, r0); 585 __ mov(r1, r0);
586 __ jmp(&do_call); 586 __ jmp(&do_call);
587 587
588 __ bind(&check_name); 588 __ bind(&check_name);
589 GenerateKeyNameCheck(masm, r2, r0, r3, &index_name, &slow_call); 589 GenerateKeyNameCheck(masm, r2, r0, r3, &index_name, &slow_call);
590 590
591 // The key is known to be a unique name. 591 // The key is known to be a unique name.
(...skipping 1061 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 } else { 1653 } else {
1654 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1654 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1655 patcher.EmitCondition(eq); 1655 patcher.EmitCondition(eq);
1656 } 1656 }
1657 } 1657 }
1658 1658
1659 1659
1660 } } // namespace v8::internal 1660 } } // namespace v8::internal
1661 1661
1662 #endif // V8_TARGET_ARCH_ARM 1662 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698