LayoutTests/fast/dom/Range/surroundContents-for-mutation.html - Issue 443103002: Range.insertNode should verify parent before setting end to it

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/surroundContents-for-mutation.html

Issue 443103002: Range.insertNode should verify parent before setting end to it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 </head>

	5 <body>

	6 <div id='container'>

	7 <p id='start'>start</p>

	8 <iframe id='test'></iframe>

	9 <p id='end'>end</p>

	10 </div>

	11 <script>

	12 var range = document.createRange();

	13 var start = document.getElementById('start');

	14 range.setStart(start.firstChild, 0);

	15 range.setEnd(start.firstChild, 0);

	16

	17 function loaded(ev) {
	Yuta Kitamura 2014/08/08 06:20:58 Urm okay, you were trying to use window.event. I d Urm okay, you were trying to use window.event. I didn't know it. As far as I know window.event is non-standard (I think Firefox does not implement it), so I advise using the passed event (\|ev\| in your code) instead of window.event. kangil_ 2014/08/08 06:32:50 Done. Show quoted text On 2014/08/08 06:20:58, Yuta Kitamura wrote: > Urm okay, you were trying to use window.event. I didn't > know it. > > As far as I know window.event is non-standard (I think > Firefox does not implement it), so I advise using > the passed event (\|ev\| in your code) instead of > window.event. Done.
	18 var srcElement = event.srcElement;

	19 range.surroundContents(document.getElementById('end'));

	20 srcElement.outerHTML = '';

	21 }

	22 document.addEventListener("load", loaded, true);

	23

	24 var testFrame = document.getElementById('test');

	25 shouldThrow("range.surroundContents(testFrame)", '"HierarchyRequestError: Failed to execute \'surroundContents\' on \'Range\': This operation would set range\'s end to parent with new offset, but there\'s no parent into which to continue."' );

	26

	27 if (window.testRunner)

	28 document.getElementById('container').outerHTML = '';

	29 </script>

	30 </body>

	31 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/surroundContents-for-mutation-expected.txt » ('j') | Source/core/dom/Range.cpp » ('J')