LayoutTests/fast/dom/Range/surroundContents-for-mutation.html - Issue 443103002: Range.insertNode should verify parent before setting end to it

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/surroundContents-for-mutation.html

Issue 443103002: Range.insertNode should verify parent before setting end to it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 </head>

	5 <body>

	6 <div id='container'>

	7 <p id='start'>start</p>

	8 <iframe id='test'></iframe>

	9 <p id='end'>end</p>

	10 </div>

	11 <script>

	12 var range = document.createRange();

	13 var start = document.getElementById('start');

	14 range.setStart(start.firstChild, 0);

	15 range.setEnd(start.firstChild, 0);

	16

	17 function loaded() {

	18 var srcElement = event.srcElement;
	Yuta Kitamura 2014/08/07 09:30:41 Does this work? You have to receive the event as t Does this work? You have to receive the event as the first argument of loaded(), don't you? kangil_ 2014/08/07 09:59:50 Please refer to https://code.google.com/p/chromium Show quoted text On 2014/08/07 09:30:41, Yuta Kitamura wrote: > Does this work? You have to receive the event as the first > argument of loaded(), don't you? Please refer to https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... . It will return the object that fired the event. Yuta Kitamura 2014/08/08 04:27:55 No, that's not .srcElement I'm talking about. I'm Show quoted text On 2014/08/07 09:59:50, kangil_ wrote: > On 2014/08/07 09:30:41, Yuta Kitamura wrote: > > Does this work? You have to receive the event as the first > > argument of loaded(), don't you? > > Please refer to > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... > . It will return the object that fired the event. No, that's not .srcElement I'm talking about. I'm asking about loaded() function taking no arguments. Where does \|event\| come from? kangil_ 2014/08/08 04:52:25 I will add event argument in next patch. Show quoted text On 2014/08/08 04:27:55, Yuta Kitamura wrote: > On 2014/08/07 09:59:50, kangil_ wrote: > > On 2014/08/07 09:30:41, Yuta Kitamura wrote: > > > Does this work? You have to receive the event as the first > > > argument of loaded(), don't you? > > > > Please refer to > > > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... > > . It will return the object that fired the event. > > No, that's not .srcElement I'm talking about. I'm asking > about loaded() function taking no arguments. Where does > \|event\| come from? I will add event argument in next patch.
	19 range.surroundContents(document.getElementById('end'));

	20 srcElement.outerHTML = '';

	21 }

	22 document.addEventListener("load", loaded, true);

	23

	24 var testFrame = document.getElementById('test');

	25 shouldThrow("range.surroundContents(testFrame)", '"HierarchyRequestError: Failed to execute \'surroundContents\' on \'Range\': This operation would set range\'s end to parent with new offset, but there\'s no parent into which to continue."' );

	26

	27 if (window.testRunner)

	28 document.getElementById('container').outerHTML = '';

	29 </script>

	30 </body>

	31 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/surroundContents-for-mutation-expected.txt » ('j') | Source/core/dom/Range.cpp » ('J')