Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 443093002: Remove Mac 10.8 x86 Perf expectations (Closed)

Created:
6 years, 4 months ago by borenet
Modified:
6 years, 4 months ago
Reviewers:
rmistry, benchen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove Mac 10.8 x86 Perf expectations This is one of the problems with the way the RecreateSKPs bot determines which trybots to run: Rather than use a hard-coded list, it figures out which bots have perf expectations and then runs those bots to generate new expectations. This is problematic when we remove a bot because we have to remove its expectations as well. This is really not that different from maintaining a hard-coded list... NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/70f25c1a3f5677ff582399e138a82653a5bfe7c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -252 lines) Patch
D expectations/bench/bench_expectations_Perf-Mac10.8-MacMini4.1-GeForce320M-x86-Release.txt View 1 chunk +0 lines, -252 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
borenet
6 years, 4 months ago (2014-08-06 13:01:07 UTC) #1
rmistry
LGTM
6 years, 4 months ago (2014-08-06 13:02:23 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 4 months ago (2014-08-06 13:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/443093002/1
6 years, 4 months ago (2014-08-06 13:03:57 UTC) #4
commit-bot: I haz the power
Change committed as 70f25c1a3f5677ff582399e138a82653a5bfe7c8
6 years, 4 months ago (2014-08-06 13:04:05 UTC) #5
benchen
The difference is that when we add a bot to run expectations, we don't need ...
6 years, 4 months ago (2014-08-06 13:16:09 UTC) #6
benchen
6 years, 4 months ago (2014-08-06 13:29:51 UTC) #7
Message was sent while issue was closed.
Actually, if we remove a bot, we don't want its expectation file to still linger
around (while only removing it from a list elsewhere)
Hopefully the expectation-based triggering will retire in a few months..

Powered by Google App Engine
This is Rietveld 408576698