Video Player: Check Cast extension before launching cast feature

Video Player: Check Cast extension before launching cast feature

If the cast extension is not install, video player doesn't activate the cast-related feature.

BUG=399557
TEST=manually tested
R=fukino@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288003

[yoshiki, 2014-08-06 13:57:10]

@fukino-san, PTAL. Thanks.

[fukino, 2014-08-07 00:35:04]

LGTM with nits.

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/cast/cast_extension_discoverer.js (right):

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/cast/cast_extension_discoverer.js:38: *     the
extension is found.
nit: @private

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/cast/cast_extension_discoverer.js:63: * @param
{function(boolean)} callback Callback to notify the result.
nit: @private

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/cast/caster.js:19: console.log(foundId);
nit: Remaining debug print? If not, more readable log should be preferable.

[yoshiki, 2014-08-07 06:33:47]

Thanks!

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/cast/cast_extension_discoverer.js (right):

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/cast/cast_extension_discoverer.js:38: *     the
extension is found.
On 2014/08/07 00:35:04, fukino wrote:
> nit: @private

Done.

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/cast/cast_extension_discoverer.js:63: * @param
{function(boolean)} callback Callback to notify the result.
On 2014/08/07 00:35:04, fukino wrote:
> nit: @private

Done.

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/443083002/diff/1/ui/file_manager/video_player...
ui/file_manager/video_player/js/cast/caster.js:19: console.log(foundId);
On 2014/08/07 00:35:04, fukino wrote:
> nit: Remaining debug print? If not, more readable log should be preferable.

It should be removed.

[yoshiki, 2014-08-07 06:33:50]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-08-07 06:34:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoshiki@chromium.org/443083002/20001

[yoshiki, 2014-08-07 07:56:25]

Committed patchset #2 manually as 288003 (presubmit successful).