Add support for RelatedEvent.

Add support for RelatedEvent.

Add support for RelatedEvent which is needed to implement contextmenu.
Specifications:
http://www.whatwg.org/specs/web-apps/current-work/#relatedevent

BUG=87553
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179626

[pals, 2014-08-06 07:22:36]

Please review.

[tkent, 2014-08-06 07:58:35]

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
File LayoutTests/fast/events/constructors/related-event-constructor.html
(right):

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:15:
shouldBe("new RelatedEvent('eventType').bubbles", "false");
Use shouldBeFalse instead of shouldBe.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:16:
shouldBe("new RelatedEvent('eventType').cancelable", "false");
Ditto.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:17:
shouldBe("new RelatedEvent('eventType').relatedTarget", "null");
shouldBeNull

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:20:
shouldBe("new RelatedEvent('eventType', { bubbles: false }).bubbles", "false");
shouldBeFalse

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:21:
shouldBe("new RelatedEvent('eventType', { bubbles: true }).bubbles", "true");
shouldBeTrue

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:24:
shouldBe("new RelatedEvent('eventType', { cancelable: false }).cancelable",
"false");
shouldBeFalse

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:25:
shouldBe("new RelatedEvent('eventType', { cancelable: true }).cancelable",
"true");
shouldBeTrue

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:51:
shouldBe("new RelatedEvent('eventType', { bubbles: true, cancelable: true,
relatedTarget: testDiv }).bubbles", "true");
shouldBeTrue

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:52:
shouldBe("new RelatedEvent('eventType', { bubbles: true, cancelable: true,
relatedTarget: testDiv }).cancelable", "true");
shouldBeTrue

[tkent, 2014-08-06 10:22:05]

Also, we should have tests to confirm behavior of updating IDL properties.  e.g.
event.bubbles = true;
event.cancelable = tru;e
event.relatedTarget = document;

[pals, 2014-08-06 12:43:55]

Added test to confirm that we cannot update readonly idl attributes.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
File LayoutTests/fast/events/constructors/related-event-constructor.html
(right):

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:15:
shouldBe("new RelatedEvent('eventType').bubbles", "false");
On 2014/08/06 07:58:35, tkent wrote:
> Use shouldBeFalse instead of shouldBe.

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:16:
shouldBe("new RelatedEvent('eventType').cancelable", "false");
On 2014/08/06 07:58:35, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:17:
shouldBe("new RelatedEvent('eventType').relatedTarget", "null");
On 2014/08/06 07:58:35, tkent wrote:
> shouldBeNull

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:20:
shouldBe("new RelatedEvent('eventType', { bubbles: false }).bubbles", "false");
On 2014/08/06 07:58:35, tkent wrote:
> shouldBeFalse

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:21:
shouldBe("new RelatedEvent('eventType', { bubbles: true }).bubbles", "true");
On 2014/08/06 07:58:35, tkent wrote:
> shouldBeTrue

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:24:
shouldBe("new RelatedEvent('eventType', { cancelable: false }).cancelable",
"false");
On 2014/08/06 07:58:35, tkent wrote:
> shouldBeFalse

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:25:
shouldBe("new RelatedEvent('eventType', { cancelable: true }).cancelable",
"true");
On 2014/08/06 07:58:35, tkent wrote:
> shouldBeTrue

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:51:
shouldBe("new RelatedEvent('eventType', { bubbles: true, cancelable: true,
relatedTarget: testDiv }).bubbles", "true");
On 2014/08/06 07:58:35, tkent wrote:
> shouldBeTrue

Done.

https://codereview.chromium.org/443053002/diff/1/LayoutTests/fast/events/cons...
LayoutTests/fast/events/constructors/related-event-constructor.html:52:
shouldBe("new RelatedEvent('eventType', { bubbles: true, cancelable: true,
relatedTarget: testDiv }).cancelable", "true");
On 2014/08/06 07:58:35, tkent wrote:
> shouldBeTrue

Done.

[tkent, 2014-08-06 12:56:02]

lgtm

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
File Source/core/events/RelatedEvent.h (right):

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
Source/core/events/RelatedEvent.h:19: static
PassRefPtrWillBeRawPtr<RelatedEvent> create();
Is this necessary?

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
Source/core/events/RelatedEvent.h:26: void
setRelatedTarget(PassRefPtrWillBeRawPtr<EventTarget> relatedTarget) {
m_relatedTarget = relatedTarget; }
EventTarget* is enough for the argument.  We don't need to use PassRefPtr, and
it's consistent with a factory method.

[pals, 2014-08-06 13:05:13]

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
File Source/core/events/RelatedEvent.h (right):

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
Source/core/events/RelatedEvent.h:19: static
PassRefPtrWillBeRawPtr<RelatedEvent> create();
On 2014/08/06 12:56:02, tkent wrote:
> Is this necessary?
This is reffered by this
https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/gen/blin...

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
Source/core/events/RelatedEvent.h:26: void
setRelatedTarget(PassRefPtrWillBeRawPtr<EventTarget> relatedTarget) {
m_relatedTarget = relatedTarget; }
On 2014/08/06 12:56:02, tkent wrote:
> EventTarget* is enough for the argument.  We don't need to use PassRefPtr, and
> it's consistent with a factory method.
> 

Done.

[pals, 2014-08-06 13:27:24]

The CQ bit was checked by sanjoy.pal@samsung.com

[commit-bot: I haz the power, 2014-08-06 13:28:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/443053002/40001

[commit-bot: I haz the power, 2014-08-06 16:12:50]

Change committed as 179626

[tkent, 2014-08-06 23:19:34]

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
File Source/core/events/RelatedEvent.h (right):

https://codereview.chromium.org/443053002/diff/20001/Source/core/events/Relat...
Source/core/events/RelatedEvent.h:26: void
setRelatedTarget(PassRefPtrWillBeRawPtr<EventTarget> relatedTarget) {
m_relatedTarget = relatedTarget; }
I think this function won't be used.  Let's remove this in a following patch if
it is unnecessary.