Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 443026: Merge r32598 to the 249 branch.... (Closed)

Created:
11 years ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge r32598 to the 249 branch. Mac: remove cursor turd from About dialog. (The cursor was displayed with full keyboard accessibility enabled.) Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|). BUG=25570 TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text). Review URL: http://codereview.chromium.org/414028 TBR=viettrungluu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -650 lines) Patch
M chrome/app/nibs/About.xib View 36 chunks +96 lines, -644 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller.mm View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Mentovai
11 years ago (2009-11-28 22:52:31 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698