Issue 443014: Merge 33144 - RESUBMIT of http://codereview.chromium.org/404025/show...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 443014: Merge 33144 - RESUBMIT of http://codereview.chromium.org/404025/show... (Closed)

Created:
11 years ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
chase

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 33144 - RESUBMIT of http://codereview.chromium.org/404025/show Start the WebKit thread when we initialize the resource dispatcher host. NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. Originally landed in r33063, reverted in r33101 due to coincidence with Modules Linux startup test failures. TBR=jorlow, darin TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144, 28364 Review URL: http://codereview.chromium.org/441025 TBR=chase@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33170

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -65 lines)			Patch
M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc	View	10 chunks	+24 lines, -28 lines	0 comments	Download
M	chrome/browser/in_process_webkit/webkit_thread.h	View	2 chunks	+4 lines, -15 lines	0 comments	Download
M	chrome/browser/in_process_webkit/webkit_thread.cc	View	3 chunks	+13 lines, -18 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages