Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: gm/rebaseline_server/imagepair_test.py

Issue 443013002: rebaseline_server: add "prefetch" directive that just warms the cache without awaiting results (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/imagepair.py ('k') | gm/rebaseline_server/server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/imagepair_test.py
diff --git a/gm/rebaseline_server/imagepair_test.py b/gm/rebaseline_server/imagepair_test.py
index ef7695acacc80af6e9873cb4e3ea8aba42de36ba..5a9f42484834818750475861076a0235a1d8606c 100755
--- a/gm/rebaseline_server/imagepair_test.py
+++ b/gm/rebaseline_server/imagepair_test.py
@@ -161,6 +161,23 @@ class ImagePairTest(unittest.TestCase):
'isDifferent': True,
},
],
+
+ # One of the two images is missing, but download_all_images=True so we
+ # should download it anyway.
+ [
+ # inputs:
+ None,
+ 'arcofzorro/13786535001616823825.png',
+ None,
+ None,
+ # expected output:
+ {
+ 'imageAUrl': None,
+ 'imageBUrl': 'arcofzorro/13786535001616823825.png',
+ 'isDifferent': True,
+ },
+ ],
+
]
db = imagediffdb.ImageDiffDB(self.temp_dir)
@@ -171,7 +188,8 @@ class ImagePairTest(unittest.TestCase):
imageA_relative_url=selftest[0],
imageB_relative_url=selftest[1],
expectations=selftest[2],
- extra_columns=selftest[3])
+ extra_columns=selftest[3],
+ download_all_images=True)
self.assertEqual(image_pair.as_dict(), selftest[4])
« no previous file with comments | « gm/rebaseline_server/imagepair.py ('k') | gm/rebaseline_server/server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698