Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 443002: Support context data in form of a string... (Closed)

Created:
11 years ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
pfeldman, yurys
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Support context data in form of a string WbeKit bug 31873 (https://bugs.webkit.org/show_bug.cgi?id=31873) changes the context "data" from a JavaScript object to a string. This chakge should support both the string and the JavaScript object format. When the WebKit change has landed the support for a JavaScript will be removed. BUG=23058 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33197

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M webkit/glue/devtools/js/debugger_agent.js View 1 2 chunks +26 lines, -2 lines 0 comments Download
M webkit/glue/devtools/js/devtools_host_stub.js View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
This is a requirement for the change in https://bugs.webkit.org/show_bug.cgi?id=31873.
11 years ago (2009-11-25 16:25:11 UTC) #1
Søren Thygesen Gjesse
11 years ago (2009-11-25 16:32:44 UTC) #2
yurys
11 years ago (2009-11-25 16:40:45 UTC) #3
LGTM

On 2009/11/25 16:32:44, Søren Gjesse wrote:
>

Powered by Google App Engine
This is Rietveld 408576698