Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 442943002: Move construction of flow_controller_ to QuicSession constructor to avoid streams being initialized… (Closed)

Created:
6 years, 4 months ago by rjshade
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move construction of flow_controller_ to QuicSession constructor to avoid streams being initialized with a NULL ptr. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M net/quic/quic_session.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 4 months ago (2014-08-05 20:56:17 UTC) #1
Ryan Hamilton
LGTM
6 years, 4 months ago (2014-08-05 20:56:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjshade@chromium.org/442943002/1
6 years, 4 months ago (2014-08-05 20:59:14 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:12:30 UTC) #4
Message was sent while issue was closed.
Change committed as 287700

Powered by Google App Engine
This is Rietveld 408576698