chrome/browser/ui/android/autofill/autofill_popup_view_android.cc - Issue 442933002: android: Don't dismiss AutofillPopup on outside touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 442933002: android: Don't dismiss AutofillPopup on outside touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/autofill/autofill_popup_view_android.h ('k') | ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

index 25e4bead143072b3ec4253fdcf0ccd2aee975e74..6e95ff9b64cbe681f3c2ff5177806b778713c4af 100644

--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

@@ -38,9 +38,9 @@ void AutofillPopupViewAndroid::Show() {

}

void AutofillPopupViewAndroid::Hide() {

+ controller_ = NULL;

JNIEnv* env = base::android::AttachCurrentThread();

Java_AutofillPopupBridge_hide(env, java_object_.obj());

- delete this;

}

void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {

@@ -84,8 +84,11 @@ void AutofillPopupViewAndroid::SuggestionSelected(JNIEnv* env,

controller_->AcceptSuggestion(list_index);

}

-void AutofillPopupViewAndroid::RequestHide(JNIEnv* env, jobject obj) {

- controller_->Hide();

+void AutofillPopupViewAndroid::PopupDismissed(JNIEnv* env, jobject obj) {

+ if (controller_)

+ controller_->ViewDestroyed();

+ delete this;

}

void AutofillPopupViewAndroid::InvalidateRow(size_t) {}