Source/platform/PODArena.h - Issue 44293004: Devirtualize PODArena and PODArena::Chunk's destructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/PODArena.h

Issue 44293004: Devirtualize PODArena and PODArena::Chunk's destructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/PODArena.h

diff --git a/Source/platform/PODArena.h b/Source/platform/PODArena.h

index bc65de6645268688242da44e51f6c560acb277c4..da9d4460fd9977d74b57d828b802bcb4c2db0c47 100644

--- a/Source/platform/PODArena.h

+++ b/Source/platform/PODArena.h

@@ -102,7 +102,6 @@ public:

};

protected:

- virtual ~PODArena() { }

friend class WTF::RefCounted<PODArena>;

PODArena()

@@ -162,7 +161,7 @@ protected:

// Frees the memory allocated from the Allocator in the

// constructor.

- virtual ~Chunk()

+ ~Chunk()

{

m_allocator->free(m_base);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »