Enable auto-reload by default.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 1105 matching lines @@
 
 std::string ChromeContentBrowserClient::GetCanonicalEncodingNameByAliasName(
     const std::string& alias_name) {
   return CharacterEncoding::GetCanonicalEncodingNameByAliasName(alias_name);
 }
 
 namespace {
 
 bool IsAutoReloadEnabled() {
   std::string group = base::FieldTrialList::FindFullName(
       "AutoReloadExperiment");

[mmenke, 2014/08/05 19:36:59]

If we're getting rid of the field trial, should get rid of this line.  If we're
just changing the value when there's no field trial, should instead change the
last line to "return group != "Disabled";"

Same goes for the other function.

[Elly Fong-Jones, 2014/08/05 19:41:56]

No, we need to leave the field trial there. The field trial will still be useful
for gathering stats (in particular, it tracks what proportions of users have
force-enabled/disabled autoreload using chrome://flags or group policy). For
that to happen, we have to call FindFullName() at least once on each trial. I
can add a comment about why it's unused if you'd like.

[mmenke, 2014/08/05 20:33:59]

I'm not following.  How does this record whether people have it enabled or
disabled by policy or about:flags?  about:flags adds a switch, and there doesn't
seem to be any way for UMA to know the switch is related to the field trial.

   const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
   if (browser_command_line.HasSwitch(switches::kEnableOfflineAutoReload))
     return true;
   if (browser_command_line.HasSwitch(switches::kDisableOfflineAutoReload))
     return false;
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
-  chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
-  chrome::VersionInfo::Channel kForceChannel =
-      chrome::VersionInfo::CHANNEL_CANARY;
-  return (channel <= kForceChannel || group == "Enabled");
-#else
-  return group == "Enabled";
-#endif
+  return true;
 }
 
 bool IsAutoReloadVisibleOnlyEnabled() {
   std::string group = base::FieldTrialList::FindFullName(
       "AutoReloadVisibleOnlyExperiment");
   const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
   if (browser_command_line.HasSwitch(
       switches::kEnableOfflineAutoReloadVisibleOnly)) {
     return true;
   }
   if (browser_command_line.HasSwitch(
       switches::kDisableOfflineAutoReloadVisibleOnly)) {
     return false;
   }
-  return group == "Enabled";
+  return true;
 }
 
 }  // namespace
 
 void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
     CommandLine* command_line, int child_process_id) {
 #if defined(OS_POSIX)
   if (breakpad::IsCrashReporterEnabled()) {
     scoped_ptr<metrics::ClientInfo> client_info =
         GoogleUpdateSettings::LoadMetricsClientInfo();
@@ skipping 1431 matching lines @@
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
 }  // namespace chrome