Issue 442893003: When getting content for a moved file w/ history, don't convert newlines in output of 'git show'

Issue 442893003: When getting content for a moved file w/ history, don't convert newlines in output of 'git show' (Closed)

Created:
6 years, 4 months ago by jrobbins

Modified:
6 years, 4 months ago

Reviewers:
Jason Robbins -- corp, agable, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Sergey Berezin

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Project:
tools

Visibility:
Public.

When getting content for a moved file w/ history, don't convert newlines in output of 'git show' BUG=339068 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287615

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	third_party/upload.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

jrobbins

PTAL. This should solve a problem with getting CLs that contain binary files uploaded to ...

6 years, 4 months ago (2014-08-05 19:14:32 UTC) #1

iannucci

d'oh! lgtm. Let's make sure to update the one in Rietveld upstream first/also.

6 years, 4 months ago (2014-08-05 21:20:58 UTC) #2

Jason Robbins -- corp

On 2014/08/05 21:20:58, iannucci wrote: > d'oh! lgtm. Let's make sure to update the one ...

6 years, 4 months ago (2014-08-05 22:13:55 UTC) #3

Jason Robbins -- corp

The CQ bit was checked by jrobbins@google.com

6 years, 4 months ago (2014-08-05 22:14:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrobbins@chromium.org/442893003/1

6 years, 4 months ago (2014-08-05 22:15:07 UTC) #5

Message was sent while issue was closed.

Change committed as 287615