Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 442883002: Fix bad gypi (Closed)

Created:
6 years, 4 months ago by Tom Hudson
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix bad gypi Must not depend directly on ports; depend on skialib! R=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/816b4fb97c5d7f1e7ad202245b049f5b2f5a35a6

Patch Set 1 #

Patch Set 2 : Attempt to fix issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M gyp/tests.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
lgtm
6 years, 4 months ago (2014-08-05 18:49:38 UTC) #1
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 4 months ago (2014-08-05 18:49:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/442883002/20001
6 years, 4 months ago (2014-08-05 18:50:48 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 19:01:13 UTC) #4
Message was sent while issue was closed.
Change committed as 816b4fb97c5d7f1e7ad202245b049f5b2f5a35a6

Powered by Google App Engine
This is Rietveld 408576698