Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 442863005: Plumb frame rate configuration into Cast Streaming API. (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, extensions-reviews_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Plumb frame rate configuration into Cast Streaming API. BUG=400930 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -21 lines) Patch
M chrome/common/extensions/api/cast_streaming_rtp_stream.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 4 chunks +27 lines, -19 lines 0 comments Download
M media/cast/cast_config.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/video_sender.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
miu
hclam: PTAL.
6 years, 4 months ago (2014-08-06 01:23:17 UTC) #1
Alpha Left Google
LGTM. Please kalman@ to review the change in extensions and idl.
6 years, 4 months ago (2014-08-06 01:27:49 UTC) #2
miu
kalman: PTAL for OWNERS approval (for the two files in chrome/common/extensions/).
6 years, 4 months ago (2014-08-06 01:29:29 UTC) #3
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-06 17:16:17 UTC) #4
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-06 17:32:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/442863005/1
6 years, 4 months ago (2014-08-06 17:35:00 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 18:51:30 UTC) #7
Message was sent while issue was closed.
Change committed as 287814

Powered by Google App Engine
This is Rietveld 408576698