Disable Poly1305 code only on bad chips.

Disable Poly1305 code only on bad chips.

This change detects buggy ARM chips and disables the Poly1305 code only on
those chips.

BUG=341598
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288267

[willchan no longer on Chromium, 2014-08-05 22:47:38]

lgtm

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc
File base/cpu.cc (right):

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc#newcode97
base/cpu.cc:97: LazyCpuInfoValue() :
Google style guide says to move the ':' to the first initializer line:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr....

Alternatively, pull the initializer list up to this line.

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc#newcode152
base/cpu.cc:152: value = value.substr(1);
I probably shouldn't care, but all the copies in this code minorly irks me. No
need to fix, just wanted to complain :P

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc#newcode183
base/cpu.cc:183: base::LazyInstance<LazyCpuInfoValue> g_lazy_cpuinfo =
Nit: Since the other singleton that uses this is leaked, I recommend leaking
this one too. Just to prevent possible (very unlikely) shutdown bugs.

[agl, 2014-08-07 01:53:49]

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc
File base/cpu.cc (right):

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc#newcode97
base/cpu.cc:97: LazyCpuInfoValue() :
On 2014/08/05 22:47:38, willchan wrote:
> Google style guide says to move the ':' to the first initializer line:
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr....
> 
> Alternatively, pull the initializer list up to this line.

Done.

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc#newcode152
base/cpu.cc:152: value = value.substr(1);
On 2014/08/05 22:47:38, willchan wrote:
> I probably shouldn't care, but all the copies in this code minorly irks me. No
> need to fix, just wanted to complain :P

Have used StringPeice to save a couple of copies, although one is still needed
before strtoul because StringPeice doesn't ensure NUL termination for .data().

https://codereview.chromium.org/442863003/diff/1/base/cpu.cc#newcode183
base/cpu.cc:183: base::LazyInstance<LazyCpuInfoValue> g_lazy_cpuinfo =
On 2014/08/05 22:47:38, willchan wrote:
> Nit: Since the other singleton that uses this is leaked, I recommend leaking
> this one too. Just to prevent possible (very unlikely) shutdown bugs.

Done.

[agl, 2014-08-07 21:38:25]

The CQ bit was checked by agl@chromium.org

[commit-bot: I haz the power, 2014-08-07 22:22:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/agl@chromium.org/442863003/40001

[commit-bot: I haz the power, 2014-08-08 08:45:31]

Change committed as 288267